linux-kernel - Re: [PATCH] hwmon: ltc4245: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <138ba352-97ac-4992-9fea-afcfe84a28b8@roeck-us.net>
Date:   Fri, 10 Mar 2023 08:30:06 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>, devicetree@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: ltc4245: Use of_property_read_bool() for boolean
 properties

On Fri, Mar 10, 2023 at 08:47:07AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Applied after s/to to/to/

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc4245.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
> index 5088d28b3a7c..57cbaf3b39fa 100644
> --- a/drivers/hwmon/ltc4245.c
> +++ b/drivers/hwmon/ltc4245.c
> @@ -434,7 +434,7 @@ static bool ltc4245_use_extra_gpios(struct i2c_client *client)
>  		return pdata->use_extra_gpios;
>  
>  	/* fallback on OF */
> -	if (of_find_property(np, "ltc4245,use-extra-gpios", NULL))
> +	if (of_property_read_bool(np, "ltc4245,use-extra-gpios"))
>  		return true;
>  
>  	return false;