linux-kernel - Re: [PATCH] hwmon: Use of_property_present() for testing DT property presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fd0857e-8198-4412-9f82-c768207338d2@roeck-us.net>
Date:   Fri, 10 Mar 2023 08:30:59 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: Use of_property_present() for testing DT property
 presence

On Fri, Mar 10, 2023 at 08:47:06AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ibmpowernv.c | 4 ++--
>  drivers/hwmon/pwm-fan.c    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 8e3724728cce..594254d6a72d 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -456,9 +456,9 @@ static int populate_attr_groups(struct platform_device *pdev)
>  		 */
>  		if (!of_property_read_string(np, "label", &label))
>  			sensor_groups[type].attr_count++;
> -		if (of_find_property(np, "sensor-data-min", NULL))
> +		if (of_property_present(np, "sensor-data-min"))
>  			sensor_groups[type].attr_count++;
> -		if (of_find_property(np, "sensor-data-max", NULL))
> +		if (of_property_present(np, "sensor-data-max"))
>  			sensor_groups[type].attr_count++;
>  	}
>  
> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> index 83a347ca35da..57928d270015 100644
> --- a/drivers/hwmon/pwm-fan.c
> +++ b/drivers/hwmon/pwm-fan.c
> @@ -427,7 +427,7 @@ static int pwm_fan_of_get_cooling_data(struct device *dev,
>  	struct device_node *np = dev->of_node;
>  	int num, i, ret;
>  
> -	if (!of_find_property(np, "cooling-levels", NULL))
> +	if (!of_property_present(np, "cooling-levels"))
>  		return 0;
>  
>  	ret = of_property_count_u32_elems(np, "cooling-levels");