linux-kernel - Re: [PATCH 2/4] pwm: cros-ec: Explicitly set .polarity in .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230310185028.z2rewz3467fvs5a3@pengutronix.de>
Date:   Fri, 10 Mar 2023 19:50:28 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Thierry Reding <thierry.reding@...il.com>,
        Munehisa Kamata <kamatam@...zon.com>,
        Benson Leung <bleung@...omium.org>
Cc:     Guenter Roeck <groeck@...omium.org>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        chrome-platform@...ts.linux.dev
Subject: Re: [PATCH 2/4] pwm: cros-ec: Explicitly set .polarity in
 .get_state()

On Tue, Feb 28, 2023 at 02:55:06PM +0100, Uwe Kleine-König wrote:
> The driver only supports normal polarity. Complete the implementation of
> .get_state() by setting .polarity accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

I think we should apply this patch as a fix to prevent similar failures
as reported for the meson driver. To justify that:

Fixes: 1f0d3bb02785 ("pwm: Add ChromeOS EC PWM driver")

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)