linux-kernel - Re: [PATCH v4 1/5] vfio: Do not allow !ops->dma_unmap in vfio_pin/unpin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 16:14:27 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Nicolin Chen <nicolinc@...dia.com>
Cc:     kevin.tian@...el.com, joro@...tes.org, will@...nel.org,
        robin.murphy@....com, alex.williamson@...hat.com, shuah@...nel.org,
        yi.l.liu@...el.com, linux-kernel@...r.kernel.org,
        iommu@...ts.linux.dev, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, mjrosato@...ux.ibm.com,
        farman@...ux.ibm.com
Subject: Re: [PATCH v4 1/5] vfio: Do not allow !ops->dma_unmap in
 vfio_pin/unpin_pages()

On Wed, Mar 08, 2023 at 06:25:58AM -0800, Nicolin Chen wrote:
> A driver that doesn't implement ops->dma_unmap shouldn't be allowed to do
> vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova
> range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages().
> 
> Suggested-by: Kevin Tian <kevin.tian@...el.com>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Reviewed-by: Yi Liu <yi.l.liu@...el.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/vfio/vfio_main.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason