linux-kernel - Re: [PATCH] power: reset: qcom-pon: drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5a6a775-19be-5e75-a4de-922fb4f0f8e8@linaro.org>
Date:   Fri, 10 Mar 2023 21:54:18 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table

On 10/03/2023 21:48, Marijn Suijten wrote:
> On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote:
>> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
>> on OF thus the driver is OF-only.  It's of_device_id table is built
> 
> Its*
> 
>> unconditionally, thus of_match_ptr() for ID table does not make sense.
> 
> Agreed.  Searching for of_match_ptr on any *qcom* file yields 25 results
> on a few-weeks-old tree, are you planning on assessing those too?
> 

There are just few incorrect usages, I'll fix these. Rest has proper
maybe_unused or ifdef.

Best regards,
Krzysztof