linux-kernel - [tip: objtool/core] alpha/cpu: Make sure arch_cpu_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <167848169589.5837.10610874531476586578.tip-bot2@tip-bot2>
Date:   Fri, 10 Mar 2023 20:54:55 -0000
From:   "tip-bot2 for Josh Poimboeuf" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Josh Poimboeuf <jpoimboe@...nel.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: objtool/core] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return

The following commit has been merged into the objtool/core branch of tip:

Commit-ID:     550db6795e9bb0b1b40f9c52bbe3d0ee735dbdb0
Gitweb:        https://git.kernel.org/tip/550db6795e9bb0b1b40f9c52bbe3d0ee735dbdb0
Author:        Josh Poimboeuf <jpoimboe@...nel.org>
AuthorDate:    Mon, 13 Feb 2023 23:05:36 -08:00
Committer:     Josh Poimboeuf <jpoimboe@...nel.org>
CommitterDate: Mon, 06 Mar 2023 15:34:03 -08:00

alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return

arch_cpu_idle_dead() doesn't return.  Make that more explicit with a
BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Link: https://lore.kernel.org/r/19ffef09a175fecb783abcd44d6bcfeade2857eb.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
---
 arch/alpha/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/alpha/kernel/process.c b/arch/alpha/kernel/process.c
index 3251102..a82fefa 100644
--- a/arch/alpha/kernel/process.c
+++ b/arch/alpha/kernel/process.c
@@ -63,6 +63,7 @@ void arch_cpu_idle(void)
 void arch_cpu_idle_dead(void)
 {
 	wtint(INT_MAX);
+	BUG();
 }
 #endif /* ALPHA_WTINT */