[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.22.394.2303102239560.3199@hadrien>
Date: Fri, 10 Mar 2023 22:40:43 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Khadija Kamran <kamrankhadijadj@...il.com>
cc: outreachy@...ts.linux.dev,
Vaibhav Hiremath <hvaibhav.linux@...il.com>,
Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: fix exceeds line length
On Fri, 10 Mar 2023, Khadija Kamran wrote:
> Length of line 182 exceeds 100 columns in file
> drivers/staging/grebus/arche-platform.c, fix by removing tabs from the
> line.
Try to rephrase without using "fix". Fix doens't give any information
about what is actually done.
julia
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
> drivers/staging/greybus/arche-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index fcbd5f71eff2..0f0fbc263f8a 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> - WD_STATE_COLDBOOT_TRIG);
> + WD_STATE_COLDBOOT_TRIG);
> spin_unlock_irqrestore(&arche_pdata->wake_lock,
> flags);
> return IRQ_WAKE_THREAD;
> --
> 2.34.1
>
>
>
Powered by blists - more mailing lists