linux-kernel - [PATCH 0/6] bus: fsl-mc: Make remove function return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 23:41:22 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Roy Pledge <Roy.Pledge@....com>, Li Yang <leoyang.li@....com>,
        Horia Geantă <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Gaurav Jain <gaurav.jain@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Vinod Koul <vkoul@...nel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Yangbo Lu <yangbo.lu@....com>,
        Diana Craciun <diana.craciun@....nxp.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Richard Cochran <richardcochran@...il.com>
Cc:     kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        dmaengine@...r.kernel.org, netdev@...r.kernel.org,
        kvm@...r.kernel.org
Subject: [PATCH 0/6] bus: fsl-mc: Make remove function return void

Hello,

many bus remove functions return an integer which is a historic
misdesign that makes driver authors assume that there is some kind of
error handling in the upper layers. This is wrong however and returning
and error code only yields an error message.

This series improves the fsl-mc bus by changing the remove callback to
return no value instead. As a preparation all drivers are changed to
return zero before so that they don't trigger the error message.

Best regards
Uwe

Uwe Kleine-König (6):
  bus: fsl-mc: Only warn once about errors on device unbind
  bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
  bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
    condition
  bus: fsl-mc: fsl-mc-allocator: Improve error reporting
  soc: fsl: dpio: Suppress duplicated error reporting on device remove
  bus: fsl-mc: Make remove function return void

 drivers/bus/fsl-mc/dprc-driver.c              | 12 ++++-----
 drivers/bus/fsl-mc/fsl-mc-allocator.c         | 27 ++++++++++---------
 drivers/bus/fsl-mc/fsl-mc-bus.c               |  7 +----
 drivers/crypto/caam/caamalg_qi2.c             |  4 +--
 drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c       |  4 +--
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  |  4 +--
 .../net/ethernet/freescale/dpaa2/dpaa2-ptp.c  |  4 +--
 .../ethernet/freescale/dpaa2/dpaa2-switch.c   |  4 +--
 drivers/soc/fsl/dpio/dpio-driver.c            |  8 +-----
 drivers/vfio/fsl-mc/vfio_fsl_mc.c             |  3 +--
 include/linux/fsl/mc.h                        |  2 +-
 11 files changed, 28 insertions(+), 51 deletions(-)


base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
-- 
2.39.1