linux-kernel - Re: Possible kernel fs block code regression in 6.2.3 umounting usb drives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAu030xtaPBGFPBS@sol.localdomain>
Date:   Fri, 10 Mar 2023 14:53:19 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     stable@...r.kernel.org, Sasha Levin <sashal@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Mike Cloaked <mike.cloaked@...il.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yu Kuai <yukuai3@...wei.com>, Genes Lists <lists@...ience.com>
Subject: Re: Possible kernel fs block code regression in 6.2.3 umounting usb
 drives

On Fri, Mar 10, 2023 at 04:08:21PM -0500, Genes Lists wrote:
> On 3/10/23 15:23, Jens Axboe wrote:
> > On 3/10/23 1:16 PM, Eric Biggers wrote:
> ...
> > But I would revert:
> > 
> > bfe46d2efe46c5c952f982e2ca94fe2ec5e58e2a
> > 57a425badc05c2e87e9f25713e5c3c0298e4202c
> > 
> > in that order from 6.2.3 and see if that helps. Adding Yu.
> > 
> Confirm the 2 Reverts fixed in my tests as well (nvme + sata drives).
> Nasty crash - some needed to be power cycled as they hung on shutdown.
> 
> Thank you!
> 
> gene
> 
> 

Great, thanks.  BTW, 6.1 is also affected.  A simple reproducer is to run:

	dmsetup create dev --table "0 128 zero"
	dmsetup remove dev

The following kconfigs are needed for the bug to be hit:

	CONFIG_BLK_CGROUP=y
	CONFIG_BLK_DEV_THROTTLING=y
	CONFIG_BLK_DEV_THROTTLING_LOW=y

Sasha or Greg, can you please revert the indicated commits from 6.1 and 6.2?

- Eric