linux-kernel - Re: [PATCH] mm: mmap: remove newline at the end of the trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230310182542.695e9933@gandalf.local.home>
Date:   Fri, 10 Mar 2023 18:25:42 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Minwoo Im <minwoo.im.dev@...il.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace

On Sat, 11 Mar 2023 08:18:00 +0900
Minwoo Im <minwoo.im.dev@...il.com> wrote:

> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
> 
> <...>-345     [006] .....    95.589290: exit_mmap: mt_mod ...
> 
> <...>-345     [006] .....    95.589413: vm_unmapped_area: addr=...
> 
> <...>-345     [006] .....    95.589571: vm_unmapped_area: addr=...
> 
> <...>-345     [006] .....    95.589606: vm_unmapped_area: addr=...
> 
> to
> 
> <...>-336     [006] .....    44.762506: exit_mmap: mt_mod ...
> <...>-336     [006] .....    44.762654: vm_unmapped_area: addr=...
> <...>-336     [006] .....    44.762794: vm_unmapped_area: addr=...
> <...>-336     [006] .....    44.762835: vm_unmapped_area: addr=...
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@...il.com>

This should go through the mm folks.

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> ---
>  include/trace/events/mmap.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
>  		__entry->align_offset = info->align_offset;
>  	),
>  
> -	TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> +	TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
>  		IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
>  		IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
>  		__entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
>  		       __entry->mt		= &mm->mm_mt;
>  	),
>  
> -	TP_printk("mt_mod %p, DESTROY\n",
> +	TP_printk("mt_mod %p, DESTROY",
>  		  __entry->mt
>  	)
>  );