linux-kernel - Re: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAu9Q9gfkJwM3szn@nixie71>
Date:   Fri, 10 Mar 2023 17:29:07 -0600
From:   Jeff LaBundy <jeff@...undy.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Munehisa Kamata <kamatam@...zon.com>,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in
 .get_state()

On Fri, Mar 10, 2023 at 07:48:15PM +0100, Uwe Kleine-König wrote:
> [To += Jeff LaBundy]
> 
> On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-König wrote:
> > The driver only supports normal polarity. Complete the implementation of
> > .get_state() by setting .polarity accordingly.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> I think we should apply this patch as a fix to prevent similar failures
> as reported for the meson driver. To justify that:
> 
> Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")

Reviewed-by: Jeff LaBundy <jeff@...undy.com>

> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |