linux-kernel - Re: [PATCH bpf-next v3 1/2] bpf: use canonical ftrace path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230310183434.64ade329@gandalf.local.home>
Date:   Fri, 10 Mar 2023 18:34:34 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     zwisler@...nel.org
Cc:     bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ross Zwisler <zwisler@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Hao Luo <haoluo@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Jiri Olsa <jolsa@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
        Song Liu <song@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Yonghong Song <yhs@...com>, linux-kselftest@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH bpf-next v3 1/2] bpf: use canonical ftrace path

On Fri, 10 Mar 2023 10:52:08 -0700
zwisler@...nel.org wrote:

> From: Ross Zwisler <zwisler@...gle.com>
> 
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
> 
> But, from Documentation/trace/ftrace.rst:
> 
>   Before 4.1, all ftrace tracing control files were within the debugfs
>   file system, which is typically located at /sys/kernel/debug/tracing.
>   For backward compatibility, when mounting the debugfs file system,
>   the tracefs file system will be automatically mounted at:
> 
>   /sys/kernel/debug/tracing
> 
> Many comments and samples in the bpf code still refer to this older
> debugfs path, so let's update them to avoid confusion.  There are a few
> spots where the bpf code explicitly checks both tracefs and debugfs
> (tools/bpf/bpftool/tracelog.c and tools/lib/api/fs/fs.c) and I've left
> those alone so that the tools can continue to work with both paths.
> 
> Signed-off-by: Ross Zwisler <zwisler@...gle.com>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve