linux-kernel - Re: [PATCH] i2c: designware: fix slave not acknowledge when address matched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230310071922.GZ62143@black.fi.intel.com>
Date:   Fri, 10 Mar 2023 09:19:22 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     liao.zenghui@....com.cn
Cc:     jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        jsd@...ihalf.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: fix slave not acknowledge when address
 matched

Hi,

On Fri, Mar 10, 2023 at 03:10:46PM +0800, liao.zenghui@....com.cn wrote:
> static inline void __i2c_dw_enable(struct dw_i2c_dev *dev)
> {
> + u32 enabled;
> +
> dev->status |= STATUS_ACTIVE;
> - regmap_write(dev->map, DW_IC_ENABLE, 1);
> + regmap_read(dev->map, DW_IC_ENABLE, &enabled);
> + regmap_write(dev->map, DW_IC_ENABLE, enabled | DW_IC_ENABLE_ENABLE);

Looks like this patch has some whitespace damage. Probably good to use
git send-email or so to make sure the formatting stays intact.