linux-kernel - Re: [PATCH v2 1/2] dt-bindings: PWM: Add StarFive PWM module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6cde3607-cc9d-ec31-2ddd-921065a3e52d@starfivetech.com>
Date:   Fri, 10 Mar 2023 16:28:26 +0800
From:   William Qiu <william.qiu@...rfivetech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Thierry Reding <thierry.reding@...il.com>,
        Hal Feng <hal.feng@...rfivetech.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: PWM: Add StarFive PWM module



On 2023/3/10 16:26, Krzysztof Kozlowski wrote:
> On 10/03/2023 08:45, William Qiu wrote:
>> Add documentation to describe StarFive Pulse Width Modulation
>> controller driver.
>> 
>> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
> 
> (...)
> 
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    pwm@...d0000 {
>> +        compatible = "starfive,jh7110-pwm";
>> +        reg = <0x120d0000 0x10000>;
>> +        clocks = <&syscrg 121>;
>> +        resets = <&syscrg 108>;
>> +        #pwm-cells=<3>;
> 
> Missing spaces around =
> 
> With above:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> 
> Best regards,
> Krzysztof
> 
Will update.
Thanks for taking time to review this patch series.

Best regards
William