linux-kernel - Re: [PATCH] splice: Remove redundant assignment to ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230310083655.w7s4svfoge4cxpnb@wittgenstein>
Date:   Fri, 10 Mar 2023 09:36:55 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] splice: Remove redundant assignment to ret

On Fri, Mar 10, 2023 at 03:48:24AM +0000, Al Viro wrote:
> On Thu, Mar 09, 2023 at 10:15:46AM +0100, Christian Brauner wrote:
> > From: Christian Brauner (Microsoft) <brauner@...nel.org>
> > 
> > 
> > On Tue, 07 Mar 2023 16:49:18 +0800, Jiapeng Chong wrote:
> > > The variable ret belongs to redundant assignment and can be deleted.
> > > 
> > > fs/splice.c:940:2: warning: Value stored to 'ret' is never read.
> > > 
> > > 
> > 
> > Thanks for the cleanup. Seems ok to do so I picked this up,
> > 
> > [1/1] splice: Remove redundant assignment to ret
> >       commit: c3a4aec055ec275c9f860e88d37e97248927d898
> 
> Which branch?

Currently still under

https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git/ fs.misc

I planned on sending a tag to Linus on Saturday.