linux-kernel - Re: [PATCHv1 02/11] power: supply: core: auto-exposure of simple-battery data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202303100854.V2YFWYZu-lkp@intel.com>
Date:   Fri, 10 Mar 2023 09:36:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Linus Walleij <linus.walleij@...aro.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCHv1 02/11] power: supply: core: auto-exposure of
 simple-battery data

Hi Sebastian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on sre-power-supply/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Reichel/dt-bindings-power-supply-adc-battery-add-binding/20230310-065229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20230309225041.477440-3-sre%40kernel.org
patch subject: [PATCHv1 02/11] power: supply: core: auto-exposure of simple-battery data
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230310/202303100854.V2YFWYZu-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/83ec4c841d68a66bc95f5e534a805e765785f934
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sebastian-Reichel/dt-bindings-power-supply-adc-battery-add-binding/20230310-065229
        git checkout 83ec4c841d68a66bc95f5e534a805e765785f934
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/power/supply/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303100854.V2YFWYZu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/power/supply/power_supply_core.c:21:
>> include/linux/power_supply.h:777:41: warning: 'power_supply_battery_info_properties' defined but not used [-Wunused-const-variable=]
     777 | static const enum power_supply_property power_supply_battery_info_properties[] = {
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/power_supply_battery_info_properties +777 include/linux/power_supply.h

   776	
 > 777	static const enum power_supply_property power_supply_battery_info_properties[] = {
   778		POWER_SUPPLY_PROP_TECHNOLOGY,
   779		POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN,
   780		POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
   781		POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
   782		POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
   783		POWER_SUPPLY_PROP_PRECHARGE_CURRENT,
   784		POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT,
   785		POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX,
   786		POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX,
   787		POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MIN,
   788		POWER_SUPPLY_PROP_TEMP_AMBIENT_ALERT_MAX,
   789		POWER_SUPPLY_PROP_TEMP_ALERT_MIN,
   790		POWER_SUPPLY_PROP_TEMP_ALERT_MAX,
   791		POWER_SUPPLY_PROP_TEMP_MIN,
   792		POWER_SUPPLY_PROP_TEMP_MAX,
   793	};
   794	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests