linux-kernel - [PATCH] crypto: tls - Use data directly in completion function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 15:59:12 +0530
From:   meenakshi.aggarwal@....com
To:     V.sethi@....com, pankaj.gupta@....com, gaurav.jain@....com,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Meenakshi Aggarwal <meenakshi.aggarwal@....com>
Subject: [PATCH] crypto: tls - Use data directly in completion function

From: Meenakshi Aggarwal <meenakshi.aggarwal@....com>

Facing build error in building tls
error: passing argument 3 of ?ahash_request_set_callback?
from incompatible pointer type [-Werror=incompatible-pointer-types]

Issue introduced after changing prototype of "crypto_completion_t"
function pointer in include/linux/crypto.h, conversion of
completion function of tls was missed.

Changes are done to use data directly in completion function of tls.

Fixes: 255e48eb1768 ("crypto: api - Use data directly in completion function")
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
---
 crypto/tls.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/tls.c b/crypto/tls.c
index e04f3b450b43..f16810238d1a 100644
--- a/crypto/tls.c
+++ b/crypto/tls.c
@@ -1,6 +1,6 @@
 /*
  * Copyright 2013 Freescale
- * Copyright 2017 NXP
+ * Copyright 2017, 2023 NXP
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
@@ -50,9 +50,9 @@ struct async_op {
 	int err;
 };
 
-static void tls_async_op_done(struct crypto_async_request *req, int err)
+static void tls_async_op_done(void *data, int err)
 {
-	struct async_op *areq = req->data;
+	struct async_op *areq = data;
 
 	if (err == -EINPROGRESS)
 		return;
-- 
2.25.1