linux-kernel - Re: Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAsKThAQPbGVUig8@lpieralisi>
Date:   Fri, 10 Mar 2023 11:45:34 +0100
From:   Lorenzo Pieralisi <lpieralisi@...nel.org>
To:     Xi Ruoyao <xry111@...111.site>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Xiaowei Song <songxiaowei@...wei.com>, stable@...r.kernel.org
Subject: Re: Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN

On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote:
> Gentle ping.
> 
> On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote:
> > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to
> > select
> > REGMAP_MMIO or vmlinux fails to link with "undefined reference to
> > `__devm_regmap_init_mmio_clk`.
> > 
> > Cc: stable@...r.kernel.org # at least for 6.1 and 6.2

I merged this (with a rewritten commit log, Fixes tag and
CC stable - please have a look and check how this has to
be written for future submissions):

https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org

This patch is dropped.

Thanks,
Lorenzo

> > Signed-off-by: Xi Ruoyao <xry111@...111.site>
> > ---
> >  drivers/pci/controller/dwc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/Kconfig
> > b/drivers/pci/controller/dwc/Kconfig
> > index 434f6a4f4041..d29551261e80 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -307,6 +307,7 @@ config PCIE_KIRIN
> >         tristate "HiSilicon Kirin series SoCs PCIe controllers"
> >         depends on PCI_MSI
> >         select PCIE_DW_HOST
> > +       select REGMAP_MMIO
> >         help
> >           Say Y here if you want PCIe controller support
> >           on HiSilicon Kirin series SoCs.
> 
> -- 
> Xi Ruoyao <xry111@...111.site>
> School of Aerospace Science and Technology, Xidian University