linux-kernel - Re: [PATCH v2 0/2] crypto: inside-secure: Handle load errors better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZAsVJjmvefrfTHwr@gondor.apana.org.au>
Date:   Fri, 10 Mar 2023 19:31:50 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jonathan McDowell <noodles@...th.li>
Cc:     Antoine Tenart <atenart@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] crypto: inside-secure: Handle load errors better

On Tue, Feb 28, 2023 at 06:28:23PM +0000, Jonathan McDowell wrote:
> 2 minor patches to improve the error handling of the safexcel driver
> when it fails to load.
> 
> Firstly, make it clear when the reason for a load failure is because the
> firmware is not available.
> 
> Secondly, ensure we clean up the ring workqueues / IRQ affinity settings
> to avoid a kernel warning when the driver fails to load.
> 
> v2:
>  - Expand error clean up to cover ring initialisation failures
> 
> Jonathan McDowell (2):
>   crypto: inside-secure: Raise firmware load failure message to error
>   crypto: inside-secure - Cleanup ring IRQ workqueues on load failure
> 
>  drivers/crypto/inside-secure/safexcel.c | 39 ++++++++++++++++++-------
>  1 file changed, 28 insertions(+), 11 deletions(-)
> 
> -- 
> 2.39.2

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt