linux-kernel - Re: [PATCH] Staging: r8188eu: Fixed block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 12:52:55 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, gregkh@...uxfoundation.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment

On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 

Hi Khadija,

As Greg said this driver is not here any longer. This makes me think that you 
forgot at least two things...

1) Please pull and rebase the staging tree every day while working on patches 
during this period of the Outreachy project. If you had done so, you would 
have noticed that your patch cannot any more be applied.

2) I saw this patch by pure luck because you forgot to Cc the Outreachy list. 
Therefore, please don't ever forget to Cc that list. Most mentors don't 
subscribe the linux-staging list.

Thanks,

Fabio

P.S.: Please use an imperative tone, both in the subject and in the commit 
message. For example this patch could have been written the following way:

staging: axis-fifo: Add "*" to multi-line comment

Add asterisks to each line of a multi-line comment to conform to the Linux 
development guidelines. Warning reported by checkpatch.pl.

Signed-off-by: [...]