linux-kernel - Re: [PATCH v2] drivers: iio: remove dead code in at91_adc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 13:59:44 +0200
From:   Eugen Hristev <eugen.hristev@...labora.com>
To:     Cheng Ziqiu <chengziqiu@...t.edu.cn>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>, linux-iio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers: iio: remove dead code in at91_adc_probe

On 3/10/23 13:31, Cheng Ziqiu wrote:
>  From the comment of platform_get_irq, it only returns non-zero IRQ
> number and negative error number, other than zero.
> 
> Fix this by removing the if condition.
> 
> Signed-off-by: Cheng Ziqiu <chengziqiu@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

Hi and thank you for the patch,

Can you try to make the subject adhere to
subsystem: area: driver: change

e.g.
iio: adc: at91-sama5d2_adc: remove dead code...

Eugen


> ---
> v1->v2: Change commit message from SoB to Reviewed-by.
>   drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index 50d02e5fc6fc..168399092590 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>   	st->dma_st.phys_addr = res->start;
>   
>   	st->irq = platform_get_irq(pdev, 0);
> -	if (st->irq <= 0) {
> -		if (!st->irq)
> -			st->irq = -ENXIO;
> -
> +	if (st->irq < 0)
>   		return st->irq;
> -	}
>   
>   	st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>   	if (IS_ERR(st->per_clk))