linux-kernel - Re: [PATCH] Staging: r8188eu: Fixed block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 13:25:50 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Khadija Kamran <kamrankhadijadj@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, gregkh@...uxfoundation.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment

On venerdì 10 marzo 2023 13:09:54 CET Dan Carpenter wrote:
> On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> > On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > > Fixed block comment by adding '*' in each line. The Check message was
> > > shown by using checkpatch.pl script.
> > > 
> > > Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> > > ---
> > > 
> > >  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> > >  1 file changed, 10 insertions(+), 9 deletions(-)
> > 
> > Hi Khadija,
> > 
> > As Greg said this driver is not here any longer. This makes me think that
> > you
> > forgot at least two things...
> > 
> > 1) Please pull and rebase the staging tree every day while working on
> > patches
> > during this period of the Outreachy project. If you had done so, you would
> > have noticed that your patch cannot any more be applied.
> 
> This patch was sent long before the driver was deleted...  The patch was
> fine and would have been applied if the driver hadn't been removed.
> 
> regards,
> dan carpenter

I'm sorry I did not look at the day of the submission.
I took for granted that this patch had been sent after the contribution period 
start date, March 6th 2023.

Thanks Dan for making me notice this mistake.

Regards,

Fabio