linux-kernel - Re: [PATCH] drm/virtio: Enable fb damage clips property for the primary plane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c556799-6a78-4b67-a4c7-4de0a8f082fa@suse.de>
Date:   Fri, 10 Mar 2023 14:20:28 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Bilal Elmoussaoui <belmouss@...hat.com>,
        Jocelyn Falempe <jfalempe@...hat.com>,
        Enric Balletbo i Serra <eballetb@...hat.com>,
        Christian Hergert <chergert@...hat.com>,
        Albert Esteve <aesteve@...hat.com>,
        Chia-I Wu <olvaffe@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...hat.com>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Gurchetan Singh <gurchetansingh@...omium.org>,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] drm/virtio: Enable fb damage clips property for the
 primary plane

Hi Javier

Am 10.03.23 um 13:59 schrieb Javier Martinez Canillas:
> Christian Hergert reports that the driver doesn't enable the property and
> that leads to always doing a full plane update, even when the driver does
> support damage clipping for the primary plane.
> 
> Don't enable it for the cursor plane, because its .atomic_update callback
> doesn't handle damage clips.
> 
> Reported-by: Christian Hergert <chergert@...hat.com>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
> 
>   drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index 4c09e313bebc..a2e045f3a000 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -390,5 +390,9 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,

virtio_gpu_plane_init() should really be two separate functions. But 
withing the constrains of the current code

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Best regards
Thomas

>   		return plane;
>   
>   	drm_plane_helper_add(plane, funcs);
> +
> +	if (type == DRM_PLANE_TYPE_PRIMARY)
> +		drm_plane_enable_fb_damage_clips(plane);
> +
>   	return plane;
>   }
> 
> base-commit: 3e853b9f89e4bcc8aa342fa350d83ff0df67d7e9

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)