linux-kernel - RE: [EXT] Re: [PATCH v6 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB8603DA275FB41A5A22491D3AE7BA9@AM9PR04MB8603.eurprd04.prod.outlook.com>
Date:   Fri, 10 Mar 2023 13:51:48 +0000
From:   Neeraj sanjay kale <neeraj.sanjaykale@....com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "marcel@...tmann.org" <marcel@...tmann.org>,
        "johan.hedberg@...il.com" <johan.hedberg@...il.com>,
        "luiz.dentz@...il.com" <luiz.dentz@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
        "hdanton@...a.com" <hdanton@...a.com>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@....com>,
        Rohit Fule <rohit.fule@....com>,
        Sherry Sun <sherry.sun@....com>
Subject: RE: [EXT] Re: [PATCH v6 3/3] Bluetooth: NXP: Add protocol support for
 NXP Bluetooth chipsets

Hi Francesco

> 
> On Fri, Mar 10, 2023 at 12:09:09PM +0000, Neeraj sanjay kale wrote:
> > > > +#define FIRMWARE_W8987       "nxp/uartuart8987_bt.bin"
> > > > +#define FIRMWARE_W8997       "nxp/uartuart8997_bt_v4.bin"
> > > > +#define FIRMWARE_W9098       "nxp/uartuart9098_bt_v1.bin"
> > > > +#define FIRMWARE_IW416       "nxp/uartiw416_bt_v0.bin"
> > > > +#define FIRMWARE_IW612       "nxp/uartspi_n61x_v1.bin.se"
> > >
> > > Where are this files coming from? Where can I download those?
> > > Is loading a combo firmware from the mwifiex driver supported?
> > We are working on submitting these files to linux-firmware. They will
> > be available under nxp/ directory once merged.
> 
> What about the combo firmware that would be downloaded by mwifiex
> driver? How is this supposed to interact with it?
If combo firmware is loaded by the mwifiex, then this driver would not detect any bootloader signatures, and would skip FW downloading and move on. Please check the nxp_setup() function.

> 
> > > > +#define HCI_NXP_PRI_BAUDRATE 115200 #define
> HCI_NXP_SEC_BAUDRATE
> > > > +3000000
> > > What if the UART device does not support 3000000 baudrate (think at
> > > limitation on the clock source/divider of the UART)? Shouldn't this
> > > be configurable?
> > We have noted this requirement and decided to design and implement on
> > this in upcoming patches along with other new features.  We have a
> > number of customers out there who have been using these chips as well
> > as the legacy Marvell chips, which need FW download at 3000000
> > baudrate, and so far there were no issues reported.  Using a lower
> > standard baudrate affects the time it takes to download the FW, which
> > we are trying to keep strictly under 5 seconds.
> 
> ok, just for you to know our hardware, using NXP SoC, will not work with this
> baudrate (no way to have it given the clock tree we have).
Got it! We will work on this requirement for sure and come up with something soon in the next patch for this driver.
FYI, firmware download takes around 20 seconds at 115200 baudrate, which is highly unacceptable by many customers. 😊

Thanks,
Neeraj