linux-kernel - Re: [PATCH] mm: hugetlb: move hugeltb sysctls to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9375f3c-bd8b-8d32-2fd2-32047005f9b5@huawei.com>
Date:   Fri, 10 Mar 2023 22:23:34 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Luis Chamberlain <mcgrof@...nel.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <muchun.song@...ux.dev>
CC:     Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>
Subject: Re: [PATCH] mm: hugetlb: move hugeltb sysctls to its own file



On 2023/3/9 20:20, Kefeng Wang wrote:
> This moves all hugetlb sysctls to its own file, also kill an
> useless hugetlb_treat_movable_handler() defination.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>   include/linux/hugetlb.h |  8 -------
>   kernel/sysctl.c         | 32 --------------------------
>   mm/hugetlb.c            | 51 ++++++++++++++++++++++++++++++++++++++---
>   3 files changed, 48 insertions(+), 43 deletions(-)
> 

> +#ifdef CONFIG_SYSCTL
> +static void hugetlb_sysctl_init(void);

Hi Luis，this should add __init as it is called by hugetlb_init,
could you help to change it, or I could send a new patch.


> +#else
> +static inline void hugetlb_sysctl_init(void) { }
> +#endif
> +
>   static int __init hugetlb_init(void)
>   {
>   	int i;
> @@ -4257,6 +4263,7 @@ static int __init hugetlb_init(void)
>   
>   	hugetlb_sysfs_init();
>   	hugetlb_cgroup_file_init();
> +	hugetlb_sysctl_init();
>   
...
> +
> +static void hugetlb_sysctl_init(void)

ditto, sorry for the mistake.

Thanks.

> +{
> +	register_sysctl_init("vm", hugetlb_table);
> +}
>   #endif /* CONFIG_SYSCTL */
>   
>   void hugetlb_report_meminfo(struct seq_file *m)