linux-kernel - Re: [PATCH] tracing: Error if a trace event has an array for a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 09:59:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     kernel test robot <lkp@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        oe-kbuild-all@...ts.linux.dev,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Douglas RAILLARD <douglas.raillard@....com>
Subject: Re: [PATCH] tracing: Error if a trace event has an array for a
 __field()

On Fri, 10 Mar 2023 16:37:09 +0800
kernel test robot <lkp@...el.com> wrote:

>    include/trace/events/rcu.h:771:17: note: in expansion of macro '__field'
>      771 |                 __field(char, rcutorturename[RCUTORTURENAME_LEN])
>          |                 ^~~~~~~

Awesome, it found the bug that this patch is suppose to find! :-)

The above needs to be changed to:

		__array(char, rcutorturename, RCUTORTURENAME_LEN)

And my patch will fail builds that have arrays in __field() macros.

Yes, I'm not going to apply this patch until the current bugs in the kernel
are fixed, because this patch will cause the kernel not to build if it has
this type of bug.

-- Steve