linux-kernel - Re: [PATCH] gpio: loongson: Remove unnecessary .owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 16:28:03 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     zhuyinbo@...ngson.cn, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] gpio: loongson: Remove unnecessary .owner

On Thu, Mar 9, 2023 at 4:18 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpio/gpio-loongson-64bit.c:225:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4450
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/gpio/gpio-loongson-64bit.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
> index 20a68e5e66c1..06213bbfabdd 100644
> --- a/drivers/gpio/gpio-loongson-64bit.c
> +++ b/drivers/gpio/gpio-loongson-64bit.c
> @@ -222,7 +222,6 @@ MODULE_DEVICE_TABLE(acpi, loongson_gpio_acpi_match);
>  static struct platform_driver loongson_gpio_driver = {
>         .driver = {
>                 .name = "loongson-gpio",
> -               .owner = THIS_MODULE,
>                 .of_match_table = loongson_gpio_of_match,
>                 .acpi_match_table = loongson_gpio_acpi_match,
>         },
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart