linux-kernel - RE: [PATCH 2/3] ufs: exynos: drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001d953bd$b3b099c0$1b11cd40$@samsung.com>
Date:   Sat, 11 Mar 2023 07:33:38 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        "'Manivannan Sadhasivam'" <mani@...nel.org>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <andersson@...nel.org>,
        "'Konrad Dybcio'" <konrad.dybcio@...aro.org>,
        <linux-scsi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: RE: [PATCH 2/3] ufs: exynos: drop of_match_ptr for ID table

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, March 11, 2023 3:15 AM
> To: Alim Akhtar <alim.akhtar@...sung.com>; James E.J. Bottomley
> <jejb@...ux.ibm.com>; Martin K. Petersen <martin.petersen@...cle.com>;
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>; Manivannan Sadhasivam
> <mani@...nel.org>; Andy Gross <agross@...nel.org>; Bjorn Andersson
> <andersson@...nel.org>; Konrad Dybcio <konrad.dybcio@...aro.org>; linux-
> scsi@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-samsung-
> soc@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> msm@...r.kernel.org
> Subject: [PATCH 2/3] ufs: exynos: drop of_match_ptr for ID table
> 
> The driver can match only via the DT table so the table should be always used
> and the of_match_ptr does not have any sense (this also allows ACPI matching
> via PRP0001, even though it is not relevant here).
> 
>   drivers/ufs/host/ufs-exynos.c:1738:34: error: ‘exynos_ufs_of_match’ defined
> but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  drivers/ufs/host/ufs-exynos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index
> 7c985fc38db1..0bf5390739e1 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -1761,7 +1761,7 @@ static struct platform_driver exynos_ufs_pltform = {
>  	.driver	= {
>  		.name	= "exynos-ufshc",
>  		.pm	= &exynos_ufs_pm_ops,
> -		.of_match_table = of_match_ptr(exynos_ufs_of_match),
> +		.of_match_table = exynos_ufs_of_match,
>  	},
>  };
>  module_platform_driver(exynos_ufs_pltform);
> --
> 2.34.1