[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4de10796-d6fc-f485-064d-cb0cecea80c8@igalia.com>
Date: Fri, 10 Mar 2023 21:17:49 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"x86@...nel.org" <x86@...nel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Dexuan Cui <decui@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
KY Srinivasan <kys@...rosoft.com>,
"wei.liu@...nel.org" <wei.liu@...nel.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"hpa@...or.com" <hpa@...or.com>,
"thomas.lendacky@....com" <thomas.lendacky@....com>,
"jpoimboe@...nel.org" <jpoimboe@...nel.org>,
"peterz@...radead.org" <peterz@...radead.org>,
"kernel-dev@...lia.com" <kernel-dev@...lia.com>,
"kernel@...ccoli.net" <kernel@...ccoli.net>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] x86/hyperv: Mark hv_ghcb_terminate() as noreturn
On 10/03/2023 18:17, Michael Kelley (LINUX) wrote:
> From: Guilherme G. Piccoli <gpiccoli@...lia.com>
>>
>> Annotate the function prototype as noreturn to prevent objtool
>> warnings like:
>
> Just curious: Should the actual function also be updated with
> __noreturn? In similar situations, such as snp_abort(), the
> __noreturn attribute is both places. I don't know what the
> guidance is on this question.
>
> In any case, thanks for doing this cleanup!
>
> Michael
Thanks Michael!
In my understanding (anybody please correct me if I'm wrong) any user of
this function that rely on this header will "inherit" the attribute -
hence, if this function is not used in any other header or statically
inside it's own definition file, it's not necessary.
But I'm glad in submitting a V3 with that if it's better, let me know.
Cheers,
Guilherme
Powered by blists - more mailing lists