linux-kernel - Re: [PATCH] gpio: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKSJXwJ20Mn=wua_7YwJ9nU4Xqq+b29mYvEw+JaoHEuhg@mail.gmail.com>
Date:   Fri, 10 Mar 2023 21:00:20 -0600
From:   Rob Herring <robh@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>, devicetree@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: Use of_property_read_bool() for boolean properties

On Fri, Mar 10, 2023 at 4:41 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Fri, Mar 10, 2023 at 3:47 PM Rob Herring <robh@...nel.org> wrote:
>
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties.
> > Convert reading boolean properties to to of_property_read_bool().
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> You are using of_property_present() rather than of_property_read_bool()
> but I'm not picky about commit message details.

ugg, well, it's the commit message that's correct. I missed updating
this one to use of_property_read_bool().

Rob

> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Yours,
> Linus Walleij