linux-kernel - Re: [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b7239e3-81f6-067e-1fd2-9dc62166d4da@gmx.de>
Date:   Sat, 11 Mar 2023 12:57:30 +0100
From:   Helge Deller <deller@....de>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] fbdev/clps711x-fb: Use
 devm_platform_get_and_ioremap_resource()

On 3/8/23 06:49, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/clps711x-fb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 45c75ff01eca..c8bfc608bd9c 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
>   	info->fix.mmio_start = res->start;
>   	info->fix.mmio_len = resource_size(res);
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	info->screen_base = devm_ioremap_resource(dev, res);
> +	info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
>   	if (IS_ERR(info->screen_base)) {
>   		ret = PTR_ERR(info->screen_base);
>   		goto out_fb_release;