linux-kernel - Re: [PATCH] fbdev: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a1432d1-e31b-55bd-c7cc-fe8645f4a188@gmx.de>
Date:   Sat, 11 Mar 2023 13:02:06 +0100
From:   Helge Deller <deller@....de>
To:     Rob Herring <robh@...nel.org>,
        Michal Simek <michal.simek@...inx.com>
Cc:     devicetree@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] fbdev: Use of_property_read_bool() for boolean properties

On 3/10/23 15:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@...nel.org>

applied.

Thanks,
Helge

> ---
>   drivers/video/fbdev/offb.c     | 4 ++--
>   drivers/video/fbdev/sm501fb.c  | 4 ++--
>   drivers/video/fbdev/tcx.c      | 3 +--
>   drivers/video/fbdev/xilinxfb.c | 3 +--
>   4 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index f7ad6bc9d02d..b97d251d894b 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -549,10 +549,10 @@ static void offb_init_nodriver(struct platform_device *parent, struct device_nod
>   	int foreign_endian = 0;
>
>   #ifdef __BIG_ENDIAN
> -	if (of_get_property(dp, "little-endian", NULL))
> +	if (of_property_read_bool(dp, "little-endian"))
>   		foreign_endian = FBINFO_FOREIGN_ENDIAN;
>   #else
> -	if (of_get_property(dp, "big-endian", NULL))
> +	if (of_property_read_bool(dp, "big-endian"))
>   		foreign_endian = FBINFO_FOREIGN_ENDIAN;
>   #endif
>
> diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
> index f743bfbde2a6..1f3cbe723def 100644
> --- a/drivers/video/fbdev/sm501fb.c
> +++ b/drivers/video/fbdev/sm501fb.c
> @@ -1737,10 +1737,10 @@ static int sm501fb_init_fb(struct fb_info *fb, enum sm501_controller head,
>
>   #if defined(CONFIG_OF)
>   #ifdef __BIG_ENDIAN
> -	if (of_get_property(info->dev->parent->of_node, "little-endian", NULL))
> +	if (of_property_read_bool(info->dev->parent->of_node, "little-endian"))
>   		fb->flags |= FBINFO_FOREIGN_ENDIAN;
>   #else
> -	if (of_get_property(info->dev->parent->of_node, "big-endian", NULL))
> +	if (of_property_read_bool(info->dev->parent->of_node, "big-endian"))
>   		fb->flags |= FBINFO_FOREIGN_ENDIAN;
>   #endif
>   #endif
> diff --git a/drivers/video/fbdev/tcx.c b/drivers/video/fbdev/tcx.c
> index 01d87f53324d..f2eaf6e7fff6 100644
> --- a/drivers/video/fbdev/tcx.c
> +++ b/drivers/video/fbdev/tcx.c
> @@ -379,8 +379,7 @@ static int tcx_probe(struct platform_device *op)
>
>   	spin_lock_init(&par->lock);
>
> -	par->lowdepth =
> -		(of_find_property(dp, "tcx-8-bit", NULL) != NULL);
> +	par->lowdepth = of_property_read_bool(dp, "tcx-8-bit");
>
>   	sbusfb_fill_var(&info->var, dp, 8);
>   	info->var.red.length = 8;
> diff --git a/drivers/video/fbdev/xilinxfb.c b/drivers/video/fbdev/xilinxfb.c
> index 1ac83900a21c..c17cfffd9a84 100644
> --- a/drivers/video/fbdev/xilinxfb.c
> +++ b/drivers/video/fbdev/xilinxfb.c
> @@ -469,8 +469,7 @@ static int xilinxfb_of_probe(struct platform_device *pdev)
>   		pdata.yvirt = prop[1];
>   	}
>
> -	if (of_find_property(pdev->dev.of_node, "rotate-display", NULL))
> -		pdata.rotate_screen = 1;
> +	pdata.rotate_screen = of_property_read_bool(pdev->dev.of_node, "rotate-display");
>
>   	platform_set_drvdata(pdev, drvdata);
>   	return xilinxfb_assign(pdev, drvdata, &pdata);