linux-kernel - Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ea91330-d49a-6b6a-f213-6f49a69b9d9b@linaro.org>
Date:   Sat, 11 Mar 2023 01:05:39 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused



On 11.03.2023 01:04, Konrad Dybcio wrote:
> 
> 
> On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>>   drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> Shouldn't this driver depend on OF?
> 
Nevermind, can't read.

Konrad
> Konrad
>>  drivers/soc/qcom/qcom_gsbi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
>> index 290bdefbf28a..f1742e5bddb9 100644
>> --- a/drivers/soc/qcom/qcom_gsbi.c
>> +++ b/drivers/soc/qcom/qcom_gsbi.c
>> @@ -114,7 +114,7 @@ struct gsbi_info {
>>  	struct regmap *tcsr;
>>  };
>>  
>> -static const struct of_device_id tcsr_dt_match[] = {
>> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
>>  	{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
>>  	{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
>>  	{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},