linux-kernel - Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Mar 2023 17:23:11 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
Cc:     Julia Lawall <julia.lawall@...ia.fr>, outreachy@...ts.linux.dev,
        vireshk@...nel.org, johan@...nel.org, elder@...nel.org,
        gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis

On Sat, Mar 11, 2023 at 04:06:51PM +0200, Menna Mahmoud wrote:
> according to Alex feedback
> 
> " I think this type of alignment is not a major problem,
> and alignment isn't done this way in general in this
> driver, it's probably OK to keep it that way. - Alex "
> 
> 
> ,I won't resubmit these patches, right?

Yeah.  Find something else to fix.

I feel like in outreachy and similar that people send a first patch and
then they get a bunch of different feedback.  And it's like checkpatch
is complaining and it's staging code so probably the code is actually
ugly in a way.  But often it's better to abandon the project instead of
getting obsessed with it.  Zoom out a bit.  Find something else where
it's obvious how to improve the code from a readability perspective.

People are giving you feedback to help you and not because they are
about that particular line of code.  They won't care if you work on
something else instead.

regards,
dan carpenter