linux-kernel - Re: [PATCH] staging: greybus: eclose macro in a do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9ae27dc-3538-5432-6a6d-3e2ff034f467@gmail.com>
Date:   Sat, 11 Mar 2023 16:51:50 +0200
From:   Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     outreachy@...ts.linux.dev, pure.logic@...us-software.ie,
        johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: eclose macro in a do - while loop


On ١١‏/٣‏/٢٠٢٣ ١٦:٠٦, Dan Carpenter wrote:
> On Sat, Mar 11, 2023 at 03:59:19PM +0200, Menna Mahmoud wrote:
>> " ERROR: Macros with multiple statements should be enclosed in a do -
>> while loop"
>>
>> Reported by checkpath.
>>
>> do loop with the conditional expression set to a constant
>> value of zero (0).This creates a loop that
>> will execute exactly one time.This is a coding idiom that
>> allows a multi-line macro to be used anywhere
>> that a single statement can be used.
>>
>> So, enclose `gb_loopback_stats_attrs` macro in do - while (0) to
>> fix checkpath error
>>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
>> ---
> This breaks the build.  You need to compile the code before sending a
> patch.
>
> regards,
> dan carpenter


I see, I thought building the file only enough. appreciate your feedback.


Thanks,

Menna