linux-kernel - Re: [PATCH 2/2] dt-bindings: pinctrl: Move k3.h to arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Mar 2023 16:46:52 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Nishanth Menon <nm@...com>, Sekhar Nori <nsekhar@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, Tero Kristo <kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: Move k3.h to arch

On 11/03/2023 14:13, Nishanth Menon wrote:
> Move the k3 pinctrl definition to arch dts folder.
> 
> While at this, fixup MAINTAINERS and header guard macro to better
> reflect the changes.
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Suggested-by: Linus Walleij <linus.walleij@...aro.org>
> Link: https://lore.kernel.org/all/c4d53e9c-dac0-8ccc-dc86-faada324beba@linaro.org/
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> 
> There is no specific case I can think of at the moment to create a
> pinctrl.dtsi for the SoCs.. So, unlike other SoCs, I had not done that
> in the series, if folks have a better opinion about this, please let us
> discuss.
> 
>  MAINTAINERS                                                 | 1 -
>  arch/arm64/boot/dts/ti/k3-am62.dtsi                         | 3 ++-
>  arch/arm64/boot/dts/ti/k3-am62a.dtsi                        | 3 ++-
>  arch/arm64/boot/dts/ti/k3-am64.dtsi                         | 3 ++-
>  arch/arm64/boot/dts/ti/k3-am65.dtsi                         | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j7200.dtsi                        | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j721e.dtsi                        | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j721s2.dtsi                       | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j784s4.dtsi                       | 3 ++-
>  .../pinctrl/k3.h => arch/arm64/boot/dts/ti/k3-pinctrl.h     | 6 +++---

Bindings are separate from other changes (also DTS). Split the patches.

(...)

>  / {
>  	model = "Texas Instruments K3 J784S4 SoC";
>  	compatible = "ti,j784s4";
> diff --git a/include/dt-bindings/pinctrl/k3.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> similarity index 94%
> rename from include/dt-bindings/pinctrl/k3.h
> rename to arch/arm64/boot/dts/ti/k3-pinctrl.h
> index 469bd29651db..6004e0967ec5 100644
> --- a/include/dt-bindings/pinctrl/k3.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h

Dropping this file is going to break existing code and I would say is
also a break of the ABI. You need to keep the header for at least one
cycle, you can add there a warning for coming deprecation.

See for example:
https://lore.kernel.org/all/20220605160508.134075-5-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof