linux-kernel - Re: [PATCH 3/5] i2c: xiic: hide OF related data for COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTfGcByJaoXG5ifOdOCRWhemendQwG42RObZpc13v-BF6A@mail.gmail.com>
Date:   Sat, 11 Mar 2023 08:34:49 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Qii Wang <qii.wang@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        linux-i2c@...r.kernel.org, chrome-platform@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH 3/5] i2c: xiic: hide OF related data for COMPILE_TEST

On Sat, Mar 11, 2023 at 3:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
>   drivers/i2c/busses/i2c-xiic.c:1202:39: error: ‘xiic_2_00’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>  drivers/i2c/busses/i2c-xiic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..806b447055fb 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1199,11 +1199,11 @@ static const struct i2c_adapter xiic_adapter = {
>         .algo = &xiic_algorithm,
>  };
>
> +#if defined(CONFIG_OF)
>  static const struct xiic_version_data xiic_2_00 = {
>         .quirks = DYNAMIC_MODE_READ_BROKEN_BIT,
>  };
>
> -#if defined(CONFIG_OF)
>  static const struct of_device_id xiic_of_match[] = {
>         { .compatible = "xlnx,xps-iic-2.00.a", .data = &xiic_2_00 },
>         { .compatible = "xlnx,axi-iic-2.1", },
> --
> 2.34.1
>