linux-kernel - Re: [PATCH] 9P FS: Fix wild-memory-access write in v9fs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5bb5ff0-1102-c7cd-c21b-c3a7f4f31717@gmail.com>
Date:   Sat, 11 Mar 2023 21:35:41 +0400
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     David Kahurani <k.kahurani@...il.com>
Cc:     ericvh@...il.com, lucho@...kov.net, asmadeus@...ewreck.org,
        linux_oss@...debyte.com, linux-kernel@...r.kernel.org,
        syzbot+cb1d16facb3cc90de5fb@...kaller.appspotmail.com,
        v9fs-developer@...ts.sourceforge.net,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] 9P FS: Fix wild-memory-access write in v9fs_get_acl


> I'm not sure what are the rules around here but I prefer to use brackets 
> more generously.

I think in this particular case they can just make the code less 
readable (considering they will not change the behavior in any way). 
However, this is eternal discussion and I saw examples of both in the 
kernel sources.