linux-kernel - Re: [PATCH v14 00/12] Parallel CPU bringup for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Mar 2023 19:23:46 +0000
From:   Tor Vic <torvic9@...lbox.org>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     Usama Arif <usama.arif@...edance.com>, dwmw2@...radead.org,
        tglx@...utronix.de, kim.phillips@....com, brgerst@...il.com,
        piotrgorski@...hyos.org, oleksandr@...alenko.name,
        arjan@...ux.intel.com, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, x86@...nel.org,
        pbonzini@...hat.com, paulmck@...nel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        rcu@...r.kernel.org, mimoja@...oja.de, hewenliang4@...wei.com,
        thomas.lendacky@....com, seanjc@...gle.com,
        fam.zheng@...edance.com, punit.agrawal@...edance.com,
        simon.evans@...edance.com, liangma@...ngbit.com
Subject: Re: [PATCH v14 00/12] Parallel CPU bringup for x86_64



On 10.03.23 20:18, Paul Menzel wrote:
> Dear Tor,
> 

Hi Paul,

> 
> Am 10.03.23 um 20:20 schrieb Tor Vic:
>> On 08.03.23 17:13, Usama Arif wrote:
>>> The main code change over v13 is to enable parallel bringup for 
>>> SEV-ES guests.
> 
> […]
> 
>>>   .../admin-guide/kernel-parameters.txt         |   3 +
>>>   arch/x86/include/asm/cpu.h                    |   1 +
>>>   arch/x86/include/asm/processor.h              |   6 +-
>>>   arch/x86/include/asm/realmode.h               |   4 +-
>>>   arch/x86/include/asm/sev-common.h             |   3 +
>>>   arch/x86/include/asm/sev.h                    |   5 +
>>>   arch/x86/include/asm/smp.h                    |  18 +-
>>>   arch/x86/include/asm/topology.h               |   2 -
>>>   arch/x86/kernel/acpi/sleep.c                  |  30 +-
>>>   arch/x86/kernel/apic/apic.c                   |   2 +-
>>>   arch/x86/kernel/apic/x2apic_cluster.c         | 126 +++---
>>>   arch/x86/kernel/asm-offsets.c                 |   1 +
>>>   arch/x86/kernel/cpu/common.c                  |   6 +-
>>>   arch/x86/kernel/cpu/topology.c                |   2 +-
>>>   arch/x86/kernel/head_64.S                     | 162 ++++++--
>>>   arch/x86/kernel/smpboot.c                     | 366 +++++++++++++-----
>>>   arch/x86/realmode/init.c                      |   3 +
>>>   arch/x86/realmode/rm/trampoline_64.S          |  27 +-
>>>   arch/x86/xen/smp_pv.c                         |   4 +-
>>>   arch/x86/xen/xen-head.S                       |   2 +-
>>>   include/linux/cpuhotplug.h                    |   2 +
>>>   include/linux/smpboot.h                       |   7 +
>>>   kernel/cpu.c                                  |  31 +-
>>>   kernel/smpboot.h                              |   2 -
>>>   24 files changed, 614 insertions(+), 201 deletions(-)
>>>
>>
>> On Linux 6.2, Zen2 and Skylake, no issues or boot problems:
>>
>> Tested-by: Tor Vic <torvic9@...lbox.org>
> 
> Thank you for testing this. It’d be great if you shared the exact timing 
> numbers too. (Just to be sure, did you also test ACPI S3 suspend/resume?)
> 

I have just tested suspend/resume on the Zen2 machine, it works.
Not yet tested on the Skylake platform.

What is the best and simplest way to get these timings numbers?

> 
> Kind regards,
> 
> Paul