linux-kernel - Re: [PATCH 09/32] pata_parport-bpck6: remove struct ppc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <428a44be-f610-139e-d8b0-b73d590b983a@omp.ru>
Date:   Sat, 11 Mar 2023 22:30:04 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Ondrej Zary <linux@...y.sk>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Tim Waugh <tim@...erelk.net>, <linux-block@...r.kernel.org>,
        <linux-parport@...ts.infradead.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/32] pata_parport-bpck6: remove struct ppc_storage

On 3/8/23 1:46 AM, Ondrej Zary wrote:

> Store the remaining two variables (cur_ctrl and ppc_flags) in struct

   s/variables/fields/, maybe?

> ppc_storage directly in pi->private and remove struct ppc_storage.
> 
> Signed-off-by: Ondrej Zary <linux@...y.sk>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

> diff --git a/drivers/ata/pata_parport/ppc6lnx.c b/drivers/ata/pata_parport/ppc6lnx.c
> index 75f9748d8de5..ee8cee6bae7c 100644
> --- a/drivers/ata/pata_parport/ppc6lnx.c
> +++ b/drivers/ata/pata_parport/ppc6lnx.c
> @@ -64,10 +64,8 @@
>  
>  //***************************************************************************
>  
> -struct ppc_storage {
> -	u8	ppc_flags;
> -	u8	cur_ctrl;				// current control port contents
> -};
> +#define CUR_CTRL	(((u8 *)&pi->private)[0])
> +#define PPC_FLAGS	(((u8 *)&pi->private)[1])

   Hm, that's a creative abuse of *unsigned long*... :-)

[...]

MBR, Sergey