linux-kernel - RE: [PATCH v5 00/34] x86: enable FRED for x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR11MB6734CD5D93F411EA5D701265A8BB9@SA1PR11MB6734.namprd11.prod.outlook.com>
Date:   Sat, 11 Mar 2023 21:29:33 +0000
From:   "Li, Xin3" <xin3.li@...el.com>
To:     "Kang, Shan" <shan.kang@...el.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
CC:     "Christopherson,, Sean" <seanjc@...gle.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "hpa@...or.com" <hpa@...or.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>
Subject: RE: [PATCH v5 00/34] x86: enable FRED for x86-64

> The following issues are seen in this round of test.
> +----------------+----------------+----------------+----------------+
> |                | x86:test_      | bpf:test_progs | x86:sysret     |
> |                | vsyscall_32    |                |    _rip_64     |
> +----------------+----------------+----------------+----------------+
> |    the 7th     |                |                |                |
> |    Intel(R)    |      FAIL      |      FAIL      |      PASS      |
> |  Core(TM) CPU  |                |                |                |
> |   6.3.0-rc1+   |                |                |                |
> +----------------+----------------+----------------+----------------+
> |    the 7th     |                |                |                |
> |    Intel(R)    |                |                |                |
> |  Core(TM) CPU  |      FAIL      |      FAIL      |      PASS      |
> | 6.3.0-rc1+ w/  |                |                |                |
> | FRED patch set |                |                |                |
> +----------------+----------------+----------------+----------------+
> | Intel Simics®  |                |                |                |
> | Simulator w/o  |      FAIL      |      FAIL      |      PASS      |
> |   FRED model   |                |                |                |
> |   6.3.0-rc1+   |                |                |                |
> +----------------+----------------+----------------+----------------+
> | Intel Simics®  |                |                |                |
> | Simulator w/o  |                |                |                |
> |   FRED model   |      FAIL      |      FAIL      |      PASS      |
> | 6.3.0-rc1+ w/  |                |                |                |
> | FRED patch set |                |                |                |
> +----------------+----------------+----------------+----------------+
> | Intel Simics®  |                |                |                |
> |  Simulator w/  |      PASS      |      FAIL      |      PASS      |
> |   FRED model   |                |                |                |
> |   6.3.0-rc1+   |                |                |                |
> +----------------+----------------+----------------+----------------+
> | Intel Simics®  |                |                |                |
> |  Simulator w/  |                |                |                |
> |   FRED model   |      PASS      |      FAIL      |      PASS      |
> | 6.3.0-rc1+ w/  |                |                |                |
> | FRED patch set |                |                |                |
> | FRED disabled  |                |                |                |
> +----------------+----------------+----------------+----------------+
> | Intel Simics®  |                |                |                |
> |  Simulator w/  |                |                |                |
> |   FRED model   |      PASS      |      HANG      |      FAIL      |
> | 6.3.0-rc1+ w/  |                |                |                |
> | FRED patch set |                |                |                |
> +----------------+----------------+----------------+----------------+
> 
> The "x86:test_vsyscall_32" is a regression since the v3 FRED patch set.

The "x86:test_vsyscall_32" test passes on the Simics FRED model, no matter
whether FRED is enabled or not, because the Simics FRED model has the RDPID
instruction support.

While on a Simics non-FRED model or the test bare metal machine, which
don't have the RDPID instruction support, the test reads CPU ID from the
GDT_ENTRY_CPUNODE entry, thus it fails due to:
https://lore.kernel.org/lkml/20230311084824.2340-1-xin3.li@intel.com/

Thanks!
  Xin