linux-kernel - Re: [PATCHv3 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4821b498-ceff-ca61-db94-29839cf5e0be@wirenboard.com>
Date:   Sun, 12 Mar 2023 13:34:50 +0300
From:   Evgeny Boger <boger@...enboard.com>
To:     Martin Zaťovič <m.zatovic1@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        gregkh@...uxfoundation.org, airlied@...hat.com, dipenp@...dia.com,
        treding@...dia.com, mwen@...lia.com, fmdefrancesco@...il.com,
        arnd@...db.de, bvanassche@....org, ogabbay@...nel.org,
        axboe@...nel.dk, mathieu.poirier@...aro.org, linux@...y.sk,
        masahiroy@...nel.org, yangyicong@...ilicon.com,
        dan.j.williams@...el.com, jacek.lawrynowicz@...ux.intel.com,
        benjamin.tissoires@...hat.com, devicetree@...r.kernel.org,
        furong.zhou@...ux.intel.com, andriy.shevchenko@...el.com,
        linus.walleij@...aro.org
Subject: Re: [PATCHv3 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand
 controller

On 3/1/23 17:28, Martin Zaťovič wrote:
> GPIO bitbanged Wiegand controller requires definitions of GPIO
> lines to be used on top of the common Wiegand properties. Wiegand
> utilizes two such lines - D0(low data line) and D1(high data line).
>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Martin Zaťovič <m.zatovic1@...il.com>
> ---
>   .../bindings/wiegand/wiegand-gpio.yaml        | 51 +++++++++++++++++++
>   MAINTAINERS                                   |  5 ++
>   2 files changed, 56 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml
> new file mode 100644
> index 000000000000..df28929f6dae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/wiegand/wiegand-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO bitbanged Wiegand interface devicetree bindings
> +
> +maintainers:
> +  - Martin Zaťovič <m.zatovic1@...il.com>
> +
> +description:
> +  This represents the GPIO lines used for bit-banged Wiegand on dedicated GPIO
> +  lines.
> +
> +allOf:
> +  - $ref: /schemas/wiegand/wiegand-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: wiegand-gpio
> +
> +  data-hi-gpios:
> +    description: GPIO used as Wiegands data-hi line.
> +    maxItems: 1
> +
> +  data-lo-gpios:
> +    description: GPIO used as Wiegands data-lo line.
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - data-hi-gpios
> +  - data-lo-gpios
In my experience, the data lines are usually labeled D0/D1, sometimes 
DATA0/DATA1. Data high/data low marking is very rare.
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    wiegand@f00 {
> +        compatible = "wiegand-gpio";
> +        pulse-len-us = <50>;
> +        interval-len-us = <2000>;
> +        frame-gap-us = <2000>;
> +        data-lo-gpios = <&gpio2 6 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +        data-hi-gpios = <&gpio2 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +
> +        /* devices */
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 23a67b32f095..91e573466d6b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22519,6 +22519,11 @@ F:	Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml
>   F:	drivers/wiegand/wiegand.c
>   F:	include/linux/wiegand.h
>   
> +WIEGAND GPIO BITBANG DRIVER
> +M:	Martin Zaťovič <m.zatovic1@...il.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml
> +
>   WIIMOTE HID DRIVER
>   M:	David Rheinsberg <david.rheinsberg@...il.com>
>   L:	linux-input@...r.kernel.org

-- 
Kind regards,
Evgeny Boger
CTO @ Wiren Board