linux-kernel - Re: [PATCH 2/2] hwmon: tmp512: mark OF related data as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad8c23e2-8a92-4fdd-b785-c485ebb597a5@roeck-us.net>
Date:   Sun, 12 Mar 2023 11:10:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Eric Tremblay <etremblay@...tech-controls.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] hwmon: tmp512: mark OF related data as maybe unused

On Sat, Mar 11, 2023 at 12:16:10PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/hwmon/tmp513.c:610:34: error: ‘tmp51x_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/tmp513.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c
> index 47bbe47e062f..78cdd2d2d875 100644
> --- a/drivers/hwmon/tmp513.c
> +++ b/drivers/hwmon/tmp513.c
> @@ -607,7 +607,7 @@ static const struct i2c_device_id tmp51x_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, tmp51x_id);
>  
> -static const struct of_device_id tmp51x_of_match[] = {
> +static const struct of_device_id tmp51x_of_match[] __maybe_unused = {
>  	{
>  		.compatible = "ti,tmp512",
>  		.data = (void *)tmp512