linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: Document rohm,bd65b60 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b5d636d7-2816-64c5-9e3f-cff5a56772db@linaro.org>
Date:   Sun, 12 Mar 2023 21:42:04 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bogdan Ionescu <bogdan.ionescu.work@...il.com>
Cc:     Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-leds@...r.kernel.or, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: Document rohm,bd65b60 bindings

On 12/03/2023 21:34, Bogdan Ionescu wrote:
>> I think yes, but what about LED on/off? Is it also shared or separate?
>> Because if it is shared, then basically it is just one LED...
> No, the outputs can be enabled independently, but I don't see any
> function in the led_classdev to do that.
> The led-sources property looks like the right thing to use for this.
> If I have effectively only one led per device, do I still need an led
> child node or is this sufficient:
> 
> +   #include <dt-bindings/leds/common.h>
> +   i2c {
> +     backlight@64 {

First of all, backlight is something a bit different/more specific - see
Documentation/devicetree/bindings/leds/backlight/

Anyway for led-sources and everything in one node, I think you do not
need any children. But this will allow you only one function and one
color...

> +       compatible = "rohm,bd65b60";
> +       reg = <0x64>;
> +
> +       led-sources = <1>, <2>;
> +       function = LED_FUNCTION_BACKLIGHT;
> +       color = <LED_COLOR_ID_WHITE>;
> +
> +       rohm,ovp = <30000000>;
> +     };
> +   };
> 
> Best regards,
> Bogdan Ionescu
> 

Best regards,
Krzysztof