linux-kernel - Re: [PATCH] mm: memory-failure: correct HWPOISON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org>
Date:   Sun, 12 Mar 2023 13:50:07 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Naoya Horiguchi <naoya.horiguchi@....com>, <linux-mm@...ck.org>,
        Miaohe Lin <linmiaohe@...wei.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config

On Fri, 10 Mar 2023 21:38:43 +0800 Kefeng Wang <wangkefeng.wang@...wei.com> wrote:

> Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to
> enable HWPoison injector module.

This is quite clear from the patch itself.  What is unclear is "why". 
Does it fix a build error?  If so, please describe and add a Fixes: if
appropriate.  Is it just a cleanup?  etcetera.

Thanks.

> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -168,7 +168,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo
>  	return true;
>  }
>  
> -#if defined(CONFIG_HWPOISON_INJECT) || defined(CONFIG_HWPOISON_INJECT_MODULE)
> +#if IS_ENABLED(CONFIG_HWPOISON_INJECT)
>  
>  u32 hwpoison_filter_enable = 0;
>  u32 hwpoison_filter_dev_major = ~0U;
> -- 
> 2.35.3