linux-kernel - Re: [PATCH v2 2/2] hwmon: tmp512: drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3a8bf6a-fecd-4eb9-826f-0f5f974d36fa@roeck-us.net>
Date:   Sun, 12 Mar 2023 14:14:53 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Eric Tremblay <etremblay@...tech-controls.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: tmp512: drop of_match_ptr for ID table

On Sun, Mar 12, 2023 at 08:37:23PM +0100, Krzysztof Kozlowski wrote:
> The driver will match mostly by DT table (even thought there is regular
> ID table) so there is little benefit in of_match_ptr (this also allows
> ACPI matching via PRP0001, even though it might not be relevant here).
> This also fixes !CONFIG_OF error:
> 
>   drivers/hwmon/tmp513.c:610:34: error: ‘tmp51x_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied.

Thanks,
Guenter

> ---
> 
> Changes since v1:
> 1. Rework patch and commit msg - drop of_match_ptr.
> ---
>  drivers/hwmon/tmp513.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c
> index 47bbe47e062f..7d5f7441aceb 100644
> --- a/drivers/hwmon/tmp513.c
> +++ b/drivers/hwmon/tmp513.c
> @@ -758,7 +758,7 @@ static int tmp51x_probe(struct i2c_client *client)
>  static struct i2c_driver tmp51x_driver = {
>  	.driver = {
>  		.name	= "tmp51x",
> -		.of_match_table = of_match_ptr(tmp51x_of_match),
> +		.of_match_table = tmp51x_of_match,
>  	},
>  	.probe_new	= tmp51x_probe,
>  	.id_table	= tmp51x_id,