linux-kernel - Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Mar 2023 22:40:36 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        arnd@...db.de, olof@...om.net, soc@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, marex@...x.de, max.krummenacher@...adex.com,
        leoyang.li@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison

On Sun, 12 Mar 2023 22:02:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 12/03/2023 21:52, Andreas Kemnade wrote:
> > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based
> > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL
> > SoC.
> >   
> 
> Thank you for your patch. There is something to discuss/improve.
[...]
> > +	pinctrl_i2c2: i2c2grp {
> > +		fsl,pins = <
> > +			MX6SL_PAD_I2C2_SCL__I2C2_SCL	 0x4001f8b1
> > +			MX6SL_PAD_I2C2_SDA__I2C2_SDA	 0x4001f8b1
> > +		>;
> > +	};
> > +
> > +	pinctrl_i2c2_sleep: i2c2grp-sleep {  
> 
> Shouldn't all groups end with 'grp' suffix? Are you sure this passes
> dtbs_check?
> 
> ...
> 
No problem with dtbs_check. But I will resend with corrected names.

Regards,
Andreas