linux-kernel - Re: drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 12 Mar 2023 23:46:41 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-pm@...r.kernel.org
Subject: Re: drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse:
 incorrect type in initializer (different base types)

Hi Bjorn,

Can you please send a follow up patch for the sparse warnings in
qcom_battmgr [0]? It looks like there are two issues:

1. qcom_battmgr_update_request.battery_id is u32 instead of __le32

2. qcom_battmgr_enable_worker is missing cpu_to_le32() when building
   struct qcom_battmgr_enable_request

[0] https://lore.kernel.org/all/202303110050.1EF6YVC5-lkp@intel.com/

> sparse warnings: (new ones prefixed by >>)
> >> drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned int [usertype] battery_id @@     got restricted __le32 [usertype] @@
>    drivers/power/supply/qcom_battmgr.c:357:31: sparse:     expected unsigned int [usertype] battery_id
>    drivers/power/supply/qcom_battmgr.c:357:31: sparse:     got restricted __le32 [usertype]
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned int [usertype] battery_id @@     got restricted __le32 [usertype] @@
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse:     expected unsigned int [usertype] battery_id
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse:     got restricted __le32 [usertype]
> >> drivers/power/supply/qcom_battmgr.c:1285:30: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] owner @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1285:30: sparse:     expected restricted __le32 [usertype] owner
>    drivers/power/supply/qcom_battmgr.c:1285:30: sparse:     got int
> >> drivers/power/supply/qcom_battmgr.c:1286:29: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] type @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1286:29: sparse:     expected restricted __le32 [usertype] type
>    drivers/power/supply/qcom_battmgr.c:1286:29: sparse:     got int
> >> drivers/power/supply/qcom_battmgr.c:1287:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] opcode @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1287:31: sparse:     expected restricted __le32 [usertype] opcode
>    drivers/power/supply/qcom_battmgr.c:1287:31: sparse:     got int

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)