linux-kernel - Re: [PATCH] nfc: st-nci: Fix use after free bug in ndlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJedcCz1vazA0NPrA69C0DqqTM742YwNXMshwY_9Uiy08XEtOg@mail.gmail.com>
Date:   Tue, 14 Mar 2023 00:56:31 +0800
From:   Zheng Hacker <hackerzheng666@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Zheng Wang <zyytlz.wz@....com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, 1395428693sheep@...il.com,
        alex000young@...il.com
Subject: Re: [PATCH] nfc: st-nci: Fix use after free bug in ndlc_remove due to
 race condition

Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 于2023年3月13日周一 14:52写道：
>
> On 12/03/2023 17:08, Zheng Wang wrote:
> > This bug influences both st_nci_i2c_remove and st_nci_spi_remove.
> > Take st_nci_i2c_remove as an example.
> >
> > In st_nci_i2c_probe, it called ndlc_probe and bound &ndlc->sm_work
> > with llt_ndlc_sm_work.
> >
> > When it calls ndlc_recv or timeout handler, it will finally call
> > schedule_work to start the work.
> >
> > When we call st_nci_i2c_remove to remove the driver, there
> > may be a sequence as follows:
> >
> > Fix it by finishing the work before cleanup in ndlc_remove
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>

Thanks for the detailed review.

Best regards,
Zheng

> Best regards,
> Krzysztof
>