| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202303140154.SFYdafUn-lkp@intel.com>
Date: Tue, 14 Mar 2023 01:27:14 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [rft, PATCH v1 1/1] gpio: Drop unused inclusions from of_gpio.h
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.3-rc2 next-20230310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpio-Drop-unused-inclusions-from-of_gpio-h/20230313-224656
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20230313144557.35856-1-andriy.shevchenko%40linux.intel.com
patch subject: [rft, PATCH v1 1/1] gpio: Drop unused inclusions from of_gpio.h
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20230314/202303140154.SFYdafUn-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b108d11788b6db9e37a6c4b3110c09cecf30a46c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/gpio-Drop-unused-inclusions-from-of_gpio-h/20230313-224656
git checkout b108d11788b6db9e37a6c4b3110c09cecf30a46c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/tty/serial/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303140154.SFYdafUn-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/tty/serial/pic32_uart.c: In function 'pic32_uart_get_mctrl':
>> drivers/tty/serial/pic32_uart.c:169:18: error: implicit declaration of function 'gpiod_get_value' [-Werror=implicit-function-declaration]
169 | else if (gpiod_get_value(sport->cts_gpiod))
| ^~~~~~~~~~~~~~~
drivers/tty/serial/pic32_uart.c: In function 'pic32_uart_probe':
>> drivers/tty/serial/pic32_uart.c:899:28: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_clk_get_optional'? [-Werror=implicit-function-declaration]
899 | sport->cts_gpiod = devm_gpiod_get_optional(dev, "cts", GPIOD_IN);
| ^~~~~~~~~~~~~~~~~~~~~~~
| devm_clk_get_optional
>> drivers/tty/serial/pic32_uart.c:899:64: error: 'GPIOD_IN' undeclared (first use in this function); did you mean 'IOC_IN'?
899 | sport->cts_gpiod = devm_gpiod_get_optional(dev, "cts", GPIOD_IN);
| ^~~~~~~~
| IOC_IN
drivers/tty/serial/pic32_uart.c:899:64: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/tty/serial/pic32_uart.c:902:9: error: implicit declaration of function 'gpiod_set_consumer_name' [-Werror=implicit-function-declaration]
902 | gpiod_set_consumer_name(sport->cts_gpiod, "CTS");
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/gpiod_get_value +169 drivers/tty/serial/pic32_uart.c
157b9394709ed5 Andrei Pistirica 2016-01-13 159
157b9394709ed5 Andrei Pistirica 2016-01-13 160 /* serial core request to return the state of misc UART input pins */
157b9394709ed5 Andrei Pistirica 2016-01-13 161 static unsigned int pic32_uart_get_mctrl(struct uart_port *port)
157b9394709ed5 Andrei Pistirica 2016-01-13 162 {
157b9394709ed5 Andrei Pistirica 2016-01-13 163 struct pic32_sport *sport = to_pic32_sport(port);
157b9394709ed5 Andrei Pistirica 2016-01-13 164 unsigned int mctrl = 0;
157b9394709ed5 Andrei Pistirica 2016-01-13 165
e9c9d3bb158df0 Andy Shevchenko 2022-08-07 166 /* get the state of CTS input pin for this port */
e9c9d3bb158df0 Andy Shevchenko 2022-08-07 167 if (!sport->cts_gpiod)
157b9394709ed5 Andrei Pistirica 2016-01-13 168 mctrl |= TIOCM_CTS;
e9c9d3bb158df0 Andy Shevchenko 2022-08-07 @169 else if (gpiod_get_value(sport->cts_gpiod))
157b9394709ed5 Andrei Pistirica 2016-01-13 170 mctrl |= TIOCM_CTS;
157b9394709ed5 Andrei Pistirica 2016-01-13 171
157b9394709ed5 Andrei Pistirica 2016-01-13 172 /* DSR and CD are not supported in PIC32, so return 1
157b9394709ed5 Andrei Pistirica 2016-01-13 173 * RI is not supported in PIC32, so return 0
157b9394709ed5 Andrei Pistirica 2016-01-13 174 */
157b9394709ed5 Andrei Pistirica 2016-01-13 175 mctrl |= TIOCM_CD;
157b9394709ed5 Andrei Pistirica 2016-01-13 176 mctrl |= TIOCM_DSR;
157b9394709ed5 Andrei Pistirica 2016-01-13 177
157b9394709ed5 Andrei Pistirica 2016-01-13 178 return mctrl;
157b9394709ed5 Andrei Pistirica 2016-01-13 179 }
157b9394709ed5 Andrei Pistirica 2016-01-13 180
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists